googleapis / nodejs-storage

Node.js client for Google Cloud Storage: unified object storage for developers and enterprises, from live data serving to data analytics/ML to data archiving.
https://cloud.google.com/storage/
Apache License 2.0
896 stars 370 forks source link

storage requester pays existing bucket methods that accept userProject: file#getMetadata failed #2406

Closed flaky-bot[bot] closed 7 months ago

flaky-bot[bot] commented 7 months ago

This test failed!

To configure my behavior, see the Flaky Bot documentation.

If I'm commenting on this issue too often, add the flakybot: quiet label and I will stop commenting.


commit: a3f4891ee60e57cc19929489cae6110b07955216 buildURL: Build Status, Sponge status: failed

danielbankhead commented 7 months ago

Extracted error:

<testcase classname="storage requester pays existing bucket methods that accept userProject" name="file#getMetadata" time="0.042">
<failure>The expression evaluated to a falsy value: (0, assert_1.default)(expectedError instanceof Error) + expected - actual -false +true AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value: (0, assert_1.default)(expectedError instanceof Error) at requesterPaysDoubleTest (build/cjs/system-test/storage.js:1445:42) at runMicrotasks (<anonymous>) at processTicksAndRejections (internal/process/task_queues.js:95:5) at async Context.<anonymous> (build/cjs/system-test/storage.js:1555:21)</failure>
</testcase>

https://github.com/googleapis/nodejs-storage/blob/a3f4891ee60e57cc19929489cae6110b07955216/system-test/storage.ts#L1817-L1817

Looks similar to:

Perhaps there was a service change enabling this functionality?

flaky-bot[bot] commented 7 months ago

Looks like this issue is flaky. :worried:

I'm going to leave this open and stop commenting.

A human should fix and close this.


When run at the same commit (a3f4891ee60e57cc19929489cae6110b07955216), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).