search

googleapis / nodejs-storage

Node.js client for Google Cloud Storage: unified object storage for developers and enterprises, from live data serving to data analytics/ML to data archiving.
https://cloud.google.com/storage/
Apache License 2.0
896 stars 370 forks source link

feat: allow setting contentEncoding during compose #2431

Closed zuozp8 closed 5 months ago

zuozp8 commented 6 months ago

Fixes #2430

google-cla[bot] commented 6 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

ddelgrosso1 commented 6 months ago

Thanks for the contribution @zuozp8. It looks like the test 

Bucket
       combine
         should make correct API request:

needs to be updated.

zuozp8 commented 6 months ago

@ddelgrosso1 sure, I updated the test

I made sure my undefined doesn't look and caused content-type to be undefined too in that test

zuozp8 commented 6 months ago

@ddelgrosso1 linter wants to change files that I didn't touch, should i change them?

wouldn't it be better to commit package-lock.json into repo to avoid unexpected version bumps?

ddelgrosso1 commented 6 months ago

@zuozp8 don't worry about them, I have another PR open that will fix them. As a general rule, we don't normally commit package locks but sometimes this is the outcome 😆

ddelgrosso1 commented 6 months ago

Thanks again for the contribution @zuozp8. I will get this merged / released after Cloud Next is over.