search

googleapis / nodejs-storage

Node.js client for Google Cloud Storage: unified object storage for developers and enterprises, from live data serving to data analytics/ML to data archiving.
https://cloud.google.com/storage/
Apache License 2.0
896 stars 370 forks source link

fix: change copyoptions type #2439

Closed vishwarajanand closed 5 months ago

vishwarajanand commented 5 months ago

Fixes https://github.com/googleapis/nodejs-storage/issues/2389

ddelgrosso1 commented 5 months ago

The change itself looks good. I think the only thing I would suggest is perhaps we add a system test and / or unit test to make sure editable metadata is set correctly during a copy.