search

googleapis / nodejs-storage

Node.js client for Google Cloud Storage: unified object storage for developers and enterprises, from live data serving to data analytics/ML to data archiving.
https://cloud.google.com/storage/
Apache License 2.0
904 stars 370 forks source link

tests: move HMAC system tests to use emulator #2461

Open ddelgrosso1 opened 7 months ago

ddelgrosso1 commented 7 months ago

Per our docs there can be up to a 3 minute delay in modifying HMAC state. As such, it is occasionally causing system tests to fail. After speaking with @BenWhitehead it appears Java sidestepped this issue by using test bench. Node should do similar to avoid the flakiness. This will require separating out the HMAC tests from the larger storage.ts system-test and then reusing the infrastructure setup from conformance tests.

ddelgrosso1 commented 3 months ago

Please undo: https://github.com/googleapis/nodejs-storage/pull/2511 once this is completed.