Incorrect host generated when specifying appEngineRouting.service in an appEngineHttpRequest - Githubissues

googleapis / nodejs-tasks

This repository is deprecated. All of its content and history has been moved to googleapis/google-cloud-node.

https://cloud.google.com/tasks/docs/

Apache License 2.0

142 stars 45 forks source link

Incorrect host generated when specifying appEngineRouting.service in an appEngineHttpRequest #641

Closed fierysolid closed 2 years ago

fierysolid commented 2 years ago

Environment details

OS: maxOS 12.4
Node.js version: 16.13.2
npm version: 8.15.0
@google-cloud/tasks version: 3.0.0

Steps to reproduce

Set the appEngineRouting.service on your appEngineHttpRequest to a custom value

task.appEngineHttpRequest = {
  httpMethod: "POST",
  headers: {
    "Content-Type": "application/json",
  },
  relativeUri,
  body: Buffer.from(JSON.stringify(payload)).toString("base64"),
  appEngineRouting: {
    service: "qa",
  },
};

Internally, the library will set the host to qa.<project-id>.appspot.com which doesn't exist. This should be qa-dot-<project-id>.appspot.com

fierysolid commented 2 years ago

In addition, when I run client.listTasks, it doesn't return any tasks that have appEngineRouting specified when I call client.listTasks from the non-default app engine service using the default service account.