Closed telpirion closed 1 year ago
Here is the summary of changes.
This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run
label or use the checkbox below:
Warning: This pull request is touching the following templated files:
README.md
is managed by synthtool
. However, a partials file can be used to update the README, e.g.: https://github.com/googleapis/nodejs-storage/blob/main/.readme-partials.yamlsamples/README.md
is managed by synthtool
. However, a partials file can be used to update the README, e.g.: https://github.com/googleapis/nodejs-storage/blob/main/.readme-partials.yamlI just clicked the box to refresh the comment from SnippetBot — I want to make sure we resolve all instances of samples in use safely so we don't end up with broken links. Are all CLs related to this migration merged?
Sent cl/501606662 to address the vision_set_endpoint
in the local variables file first since it'll propagate to other pages.
Sent cl/501614555 to address the remaining region_tag updates. Let's wait for these to be merged and for SnippetBot to be happy before deleting these.
Both CLs are submitted, just waiting for the SnippetBot index to pick up changes and make sure I didn't miss any.
Ok, looks like I missed two region tags somewhere, so will send another CL updating those. Stay tuned. :)
Sent cl/501719994.
Ok, last CL has been submitted, just waiting for SnippetBot index to update. The samples test is failing (expected) so I think we also might want to remove the samples tests in this PR (or, ok to merge as-is and remove the tests in a follow-up PR).
SnippetBot is happy! Removing the do not merge
label and it's ok to ignore the samples test failure.
Samples have been moved here:
https://github.com/GoogleCloudPlatform/nodejs-docs-samples/tree/main/vision