alexander-fenster commented 4 years ago

BREAKING CHANGE: The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.

codecov[bot] commented 4 years ago

Codecov Report

Merging #139 into master will increase coverage by 2.42%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
+ Coverage   58.62%   61.05%   +2.42%     
==========================================
  Files           2        2              
  Lines       18841    18841              
  Branches        1        1              
==========================================
+ Hits        11046    11503     +457     
+ Misses       7795     7338     -457

Impacted Files	Coverage Δ
protos/protos.js	`60.99% <0%> (+2.42%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9bb011d...414ba48. Read the comment docs.

googlebot commented 4 years ago

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

AVaksman commented 4 years ago

@googlebot I consent.

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googleapis / nodejs-web-risk

feat!: drop node8 support #139

Codecov Report