search

googleapis / packman

Google API package creator
https://npmjs.com/package/googleapis-packman
Apache License 2.0
13 stars 18 forks source link

Fix protoc arguments. #102

Closed jmuk closed 8 years ago

jmuk commented 8 years ago

protoc commandline invocation fails when protoCompilerArgs is empty (i.e. prevent adding an empty string '' as a parameter).

Fixes #101.

codecov-io commented 8 years ago

Current coverage is 88.32% (diff: 100%)

Merging #102 into master will not change coverage

@@             master       #102   diff @@
==========================================
  Files             3          3          
  Lines           728        728          
  Methods         151        151          
  Messages          0          0          
  Branches        112        113     +1   
==========================================
  Hits            643        643          
  Misses           85         85          
  Partials          0          0

Powered by Codecov. Last update 8828e64...0effe3d

garrettjonesgoogle commented 8 years ago

LGTM

landrito commented 8 years ago

LGTM