search

googleapis / packman

Google API package creator
https://npmjs.com/package/googleapis-packman
Apache License 2.0
13 stars 18 forks source link

Python depends on grpcio, rather than grpc. #105

Closed bjwatson closed 8 years ago

bjwatson commented 8 years ago

See for historical context: https://bitbucket.org/seewind/grpc/issues/1/naming-collision-with-grpc-grpc

Updates https://github.com/GoogleCloudPlatform/gcloud-python/issues/2238

garrettjonesgoogle commented 8 years ago

I defer to @jmuk

bjwatson commented 8 years ago

@jmuk The build for nodejs:4 seems to be flaky. Have you seen this before?

codecov-io commented 8 years ago

Current coverage is 88.34% (diff: 100%)

Merging #105 into master will not change coverage

@@             master       #105   diff @@
==========================================
  Files             3          3          
  Lines           729        729          
  Methods         151        151          
  Messages          0          0          
  Branches        112        112          
==========================================
  Hits            644        644          
  Misses           85         85          
  Partials          0          0

Powered by Codecov. Last update 6b26c3d...ae3abc3

jmuk commented 8 years ago

It looks like a test timeout of unrelated thing (stuck on something?). Reran the test and succeeded. There might be time consuming factors in some tests, which isn't ideal, but you don't have to deal with that right now. LGTM.

bjwatson commented 8 years ago

@jmuk I bumped semver since your LGTM. PTAL

jmuk commented 8 years ago

still LGTM