Make grpcio dep optional for Python googleapis-common-protos

googleapis / packman

Google API package creator

https://npmjs.com/package/googleapis-packman

Apache License 2.0

13 stars 18 forks source link

Make grpcio dep optional for Python googleapis-common-protos #107

Closed bjwatson closed 8 years ago

bjwatson commented 8 years ago

Updates https://github.com/GoogleCloudPlatform/gcloud-python/issues/2117

NB I deliberately did not add the optional [grpc] dependency to the gax-google-* packages. They'll currently get grpcio transitively from the grpc-google-* packages, and I'm thinking forward to when gax-google-* might also support HTTP/JSON (and thus not need a gRPC dependency).

codecov-io commented 8 years ago

Current coverage is 88.34% (diff: 100%)

Merging #107 into master will not change coverage

@@             master       #107   diff @@
==========================================
  Files             3          3          
  Lines           729        729          
  Methods         151        151          
  Messages          0          0          
  Branches        112        112          
==========================================
  Hits            644        644          
  Misses           85         85          
  Partials          0          0

Powered by Codecov. Last update df0c73d...ae47e83

jmuk commented 8 years ago

LGTM