search

googleapis / packman

Google API package creator
https://npmjs.com/package/googleapis-packman
Apache License 2.0
13 stars 18 forks source link

Bump version for new release #108

Closed geigerj closed 8 years ago

codecov-io commented 8 years ago

Current coverage is 88.34% (diff: 100%)

Merging #108 into master will not change coverage

@@             master       #108   diff @@
==========================================
  Files             3          3          
  Lines           729        729          
  Methods         151        151          
  Messages          0          0          
  Branches        112        112          
==========================================
  Hits            644        644          
  Misses           85         85          
  Partials          0          0

Powered by Codecov. Last update 5a4b086...962c0a1

jmuk commented 8 years ago

I think it's better to wait for https://github.com/googleapis/packman/pull/109 too (I've also forgotten about https://github.com/googleapis/packman/pull/95, but I want to have it as well, if possible).

geigerj commented 8 years ago

I needed to do this to fix artman remote stability issues -- I actually already published it to npm. Can we just bump to 0.8.5 for the outstanding issues?

geigerj commented 8 years ago

In any case, I think there is probably a bit more discussion to be had on #109 due to https://github.com/GoogleCloudPlatform/google-cloud-python/issues/1893#issuecomment-245410626

jmuk commented 8 years ago

LGTM if you've already pushed a new package to npm -- but the bug of #109 looks like you'll have to push yet another version quite soon after it's merged.