search

googleapis / packman

Google API package creator
https://npmjs.com/package/googleapis-packman
Apache License 2.0
13 stars 18 forks source link

Python, Ruby: use protoGenPackageDeps #135

Open jmuk opened 8 years ago

jmuk commented 8 years ago

--proto_gen_pkg_dep flag has been added by @garrettjonesgoogle for mixin support, but it's not yet used for other langauges. Especially Python and Ruby package template should use them for additional dependencies.

jmuk commented 8 years ago

Cc: @geigerj

landrito commented 8 years ago

Would a simple map between proto_gen_pkg_dep to package name for each language suffice or should more sophisticated logic be used?

garrettjonesgoogle commented 8 years ago

proto_gen_pkg_dep is just supposed to refer to the api_name used in the consumed package. In general, this just means prefixing "grpc-" (for Java).

landrito commented 8 years ago

Ah I see. I didn't realize that this was the case for Python and Ruby as well.

So should the assumption be to prefix with "grpc-" unless it is google-common-protos or otherwise specified?

garrettjonesgoogle commented 8 years ago

Yeah. FYI in Java, we even do the same thing for google-common-protos :-)

landrito commented 8 years ago

Gotcha! Thanks for the clarification!