search

googleapis / packman

Google API package creator
https://npmjs.com/package/googleapis-packman
Apache License 2.0
13 stars 18 forks source link

Fix protoc version in java build template #65

Closed shinfan closed 8 years ago

shinfan commented 8 years ago

Packman was using incompatible versions of protobuf which causes compile erros in the generated grpc package.

geigerj commented 8 years ago

@garrettjonesgoogle Can you confirm that this is the right version to be using?

codecov-io commented 8 years ago

Current coverage is 88.42% (diff: 100%)

Merging #65 into master will not change coverage

@@             master        #65   diff @@
==========================================
  Files             3          3          
  Lines           674        674          
  Methods         132        132          
  Messages          0          0          
  Branches        103        103          
==========================================
  Hits            596        596          
  Misses           78         78          
  Partials          0          0

Powered by Codecov. Last update c490fc5...984a1cb

shinfan commented 8 years ago

Our grpc-core-proto is using protoc-beta1, so using beta-3 here causes compile errors.

I can update the grpc-core-proto to use beta3 and see if it fixes the issue.

shinfan commented 8 years ago

Updating core-proto fixed the issue. PTAL.

geigerj commented 8 years ago

LGTM