search

googleapis / packman

Google API package creator
https://npmjs.com/package/googleapis-packman
Apache License 2.0
13 stars 18 forks source link

Kill the isGoogleApi flag #74

Closed geigerj closed 8 years ago

geigerj commented 8 years ago

We are not using this flag anywhere, and it's better not to have special logic for Google APIs. In the implementation, a variable of the same name remains because it is necessary to support the GitHub zip archive use case.

codecov-io commented 8 years ago

Current coverage is 88.56% (diff: 100%)

Merging #74 into master will not change coverage

@@             master        #74   diff @@
==========================================
  Files             3          3          
  Lines           717        717          
  Methods         150        150          
  Messages          0          0          
  Branches        106        106          
==========================================
  Hits            635        635          
  Misses           82         82          
  Partials          0          0

Powered by Codecov. Last update ca3577a...71c7c89

jmuk commented 8 years ago

LGTM, with a nit: "isGoogleApi" is actually referred from the doc-comments for some methods in api_repo.js (setUp(), buildPackages(), buildGaxPackages()). It's nice to be removed there.