search

googleapis / packman

Google API package creator
https://npmjs.com/package/googleapis-packman
Apache License 2.0
13 stars 18 forks source link

Java: supporting common protos package with compiled classes #86

Closed garrettjonesgoogle closed 8 years ago

garrettjonesgoogle commented 8 years ago

This is so that we can switch artman to use packman for JavaCorePipeline instead of the proto generation inside artman.

geigerj commented 8 years ago

Two nits, and please fix CI failure. (Looks like the linter -- you can invoke it on the command line by npm run lint.)

garrettjonesgoogle commented 8 years ago

Issues addressed - PTAL

geigerj commented 8 years ago

LGTM (assuming CI passes)

codecov-io commented 8 years ago

Current coverage is 88.57% (diff: 100%)

Merging #86 into master will increase coverage by 0.01%

@@             master        #86   diff @@
==========================================
  Files             3          3          
  Lines           717        718     +1   
  Methods         150        150          
  Messages          0          0          
  Branches        106        107     +1   
==========================================
+ Hits            635        636     +1   
  Misses           82         82          
  Partials          0          0

Powered by Codecov. Last update adfe3c0...ec5cdcc

shinfan commented 8 years ago

LGTM