search

googleapis / packman

Google API package creator
https://npmjs.com/package/googleapis-packman
Apache License 2.0
13 stars 18 forks source link

Update gRPC dependency for Python #96

Closed bjwatson closed 8 years ago

bjwatson commented 8 years ago

@jmuk @garrettjonesgoogle I noticed that your languages are on older versions of gRPC. Do they no longer use packman?

garrettjonesgoogle commented 8 years ago

@bjwatson No, Java does use packman. We are indeed on 0.15.0 currently.

geigerj commented 8 years ago

The tests are failing because one of the files edited is a test fixture (baseline), and the testdata comes from here instead of from the real configuration. You shouldn't need to change the tests to update the config.

bjwatson commented 8 years ago

@geigerj Does that mean the tests are rotting?

garrettjonesgoogle commented 8 years ago

I would prefer the term "maturing."

geigerj commented 8 years ago

I don't think the tests should depend on configuration at all -- I just think of the values in there as fake data.

codecov-io commented 8 years ago

Current coverage is 88.57% (diff: 100%)

Merging #96 into master will not change coverage

@@             master        #96   diff @@
==========================================
  Files             3          3          
  Lines           718        718          
  Methods         150        150          
  Messages          0          0          
  Branches        107        107          
==========================================
  Hits            636        636          
  Misses           82         82          
  Partials          0          0

Powered by Codecov. Last update d06ec87...9125403

geigerj commented 8 years ago

LGTM

bjwatson commented 8 years ago

@garrettjonesgoogle My term is so much more colorful. :)

Thanks @geigerj. I'll leave that value alone for now, but suggest we revisit it again later. It will confuse others (and possible me again) in the future.