Open meredithslota opened 1 year ago
I believe the two bars are from (a) running the query and (b) downloading the data. These are created in two very different places in the code, so implementing this will require some refactoring.
@tswast @meredithslota
If the two progress bars represent two separate processes (running the query and downloading the data), as Tim describes, do we need to refactor this to create only one progress bar OR is it more informative for the user to have the two progress bars for long running processes OR large data downloads?
If we choose to go with only one bar.... seems like the "running the query" bar is generally more informative on a system level.
Per https://github.com/googleapis/python-bigquery/pull/1965 moving to bigquery-magics repo.
Regarding choosing one progress bar, we could perhaps instead output a link to the job for long-running queries:
for this job linking logic in BigQuery DataFrames.
See also: https://github.com/googleapis/python-bigquery-magics/issues/15#issuecomment-2195564214
I only have one nitpick regarding the new progress bar setup: it's a bit weird to have two progress bars, and one of them is pushed to the right when the job ID appears:
I suppose it would be better to have just a single progress bar on its own line (job ID should be its own line too).
If you want to make the output more complete, I've been also showing the data processed at the very end in my own bigquery magic like this:
With this addition the output looks like this:
It might look better if you add a colon after the "Job ID" too, but that's just my subjective preference.
Originally posted by @GergelyKalmar in https://github.com/googleapis/python-bigquery/issues/1146#issuecomment-1305399150