googleapis / python-bigquery-sqlalchemy

SQLAlchemy dialect for BigQuery
MIT License
434 stars 129 forks source link

feat: support UPDATE + JOIN in BigQuery dialect #1083

Closed Linchin closed 4 months ago

Linchin commented 4 months ago

The parent class SQLCompiler doesn't implement update_from_clause(), and thus does not support UPDATE + JOIN. This PR uses the implementation in PostgreSQL to support this.

Thanks to @brian-pond for the thorough investigation!

P.S. We added a third_party folder to vendor a code snippet from the postgresql portion of the sqlalchemy code. For future reference, in order to add vendored code, we need to do the following (for the exact change detail, check the content of this PR):

Thanks to @tswast for helping figure out the copyright and code vendoring details 🙂

Fixes #1010 🦕