googleapis / python-bigquery

Apache License 2.0
746 stars 306 forks source link

feat: add prefer_bqstorage_client option for Connection #1945

Closed Linchin closed 5 months ago

Linchin commented 5 months ago

This gives users the option to not use the Storage client if they prefer the REST client.

Fixes #1920 🦕

Linchin commented 5 months ago

QUESTION: Would we consider this a breaking change since we are moving to having a default setting of True instead of False which is what I feel like the current setting is.

I am approving this, pending an answer to the above question. Would be happy to get in a chat OR a meeting to discuss, as need. be.

Thanks for the question! The default behavior in the past is True. As in https://github.com/googleapis/python-bigquery/issues/1920, the customer couldn't disable the storage client unless they uninstall the package altogether.