Feat: Add classes and objects to enable PANGEA support

googleapis / python-bigquery

Apache License 2.0

746 stars 306 forks source link

Feat: Add classes and objects to enable PANGEA support #2012

Open chalmerlowe opened 2 months ago

chalmerlowe commented 2 months ago

WIP: do not merge.

Internal reference: b/358215039

conventional-commit-lint-gcf[bot] commented 2 months ago

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot https://conventionalcommits.org/

chalmerlowe commented 2 months ago

@Linchin

Can you take a preliminary pass through this PR?

It is incomplete. It currently only has about two classes and some getters/setters.
But before I expend too much energy...
- checking to see if this approach makes sense
- do you have any edits that I might need to make on all the additional classes, setters, getters, attributes, etc that I will be generating to finish off this task.

I will send you links in internal chat with some additional details.

Linchin commented 2 months ago

Thank you for working to add PANGEA support! It's great that I can do a quick review early to make sure we are on the same page. I think the approach looks good, but I left a few comments on implementation details.

Also, before generating the rest, I think it'd be helpful to add tests to ensure the current code is working as intended.

chalmerlowe commented 2 months ago

Thank you for working to add PANGEA support! It's great that I can do a quick review early to make sure we are on the same page. I think the approach looks good, but I left a few comments on implementation details.

Also, before generating the rest, I think it'd be helpful to add tests to ensure the current code is working as intended.

Tests are next on my list for this first batch of classes. With some proof of concept classes and tests in hand, we should be able to move on and add the remaining classes.