search

googleapis / python-bigquery

Apache License 2.0
746 stars 306 forks source link

[OpenTelemetry] Can we add the `db.query.text` attribute to the spans? #2042

Open Kludex opened 1 month ago

Kludex commented 1 month ago

Hi there,

I was wondering if it would be possible to add the query itself in the span attributes. The list of official OTel attributes for db are listed here.

I'm happy to implement it, if wanted.

williamlac commented 3 weeks ago

+1

This would be a great addition to help us identify which span is related to which of our queries in a much faster way.

samuelcolvin commented 3 weeks ago

This would be great, @chelsea-lin can you let us know if you would accept a PR for this?

Kludex commented 4 days ago

Hoi 👋

Friendly ping 🏓 😃

chelsea-lin commented 4 days ago

@Kludex Thank you! It sounds good to me! Please go ahead to start the PR please.