search

googleapis / python-bigtable

Apache License 2.0
68 stars 58 forks source link

chore: update templated files #1016

Closed gcf-owl-bot[bot] closed 2 months ago

gcf-owl-bot[bot] commented 3 months ago

Source-Link: https://github.com/googleapis/synthtool/commit/373d00fed32729afc9f53e24dce3f1cdd339678e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2dc6f67639bee669c33c6277a624ab9857d363e2fd33ac5b02d417b7d25f1ffc

parthea commented 3 months ago

The Kokoro docs-presubmit job will be removed in cl/667593059

daniel-sanche commented 3 months ago

So is the docs-presubmit check not doing anything useful? Will the docs still update as expected even if the test fails?

parthea commented 3 months ago

So is the docs-presubmit check not doing anything useful?

Correct. The publish docs job runs /.kokoro/publish-docs.sh here where as the current docs presubmit job runs /.kokoro/build.sh here. When we call build.sh in the docs-presubmit job we're just running the docs/docfx nox sessions which is already done using Github Actions(See docfx presubmit). We're not testing the publish-docs.sh script or the Dockerfile here.

Will the docs still update as expected even if the test fails?

Yes, the docs job can succeed even thought the presubmit fails because they are 2 different scripts as noted above. In addition, the docker file is built on the fly. I've filed a bug to remove this step to improve the success of the jobs pipeline: https://github.com/googleapis/synthtool/issues/2007

parthea commented 3 months ago

Wait for cl/667593059