chore(docs): use read_rows_stream in filter samples

daniel-sanche commented 2 months ago

replace read_rows with read_rows_stream, as it is more efficient

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[ ] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes # 🦕

igorbernstein2 commented 2 months ago

what makes this more efficient?

daniel-sanche commented 2 months ago

what makes this more efficient?

context: b/347322404

read_rows buffers the entire output before returning the resulting list, read_rows_stream streams gives a generator for acting on the results as they arrive

daniel-sanche commented 1 month ago

After discussing this offline, I think we will leave as-is

googleapis / python-bigtable

chore(docs): use read_rows_stream in filter samples #1020