googleapis / python-bigtable

Apache License 2.0
68 stars 59 forks source link

fix: registering duplicate instance #1033

Closed daniel-sanche closed 2 weeks ago

daniel-sanche commented 3 weeks ago

Previously, creating multiple Table objects pointed at the same (instance, table, app_profile_id) would cause duplicate ping_and_warm calls, even though the table should already be warm. This was because the registration logic was checking for the presence of the instance_name, even though the _active_instances store was actually storing instance_keys

This PR fixes the bug, and adds a new unit test