googleapis / python-bigtable

Apache License 2.0
68 stars 58 forks source link

feat: client side metrics #886

Closed daniel-sanche closed 8 months ago

daniel-sanche commented 10 months ago

This PR adds the overall structure for collecting client-side metrics, and writing them to OpenTelemetry.

Reviewers: Look at the _metrics folder first for the atchitecture of how metrics are handled. Then look at the client, _read_rows, and _mutate_rows files to see how it is used in the library. If this PR is too large to review at once, let me know and I can break it up into chunks, now that I have the overall structure in place

Benhmarking:

TODO (future PRs):

daniel-sanche commented 10 months ago

Also any idea how much overhead this adds?

I haven't had a chance to do benchmarks with this yet. The ones I'm most concerned about are the two I haven't added yet: application_blocking_latencies and throttling_latencies

daniel-sanche commented 8 months ago

closing in favor of smaller PRs