googleapis / python-bigtable

Apache License 2.0
68 stars 58 forks source link

feat: add cloud workflow for exporting vector data from Bigtable to Vertex Vector Search #930

Closed ron-gal closed 7 months ago

ron-gal commented 8 months ago

…x Vector Search

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

This is a Bigtable version of https://github.com/cloudspannerecosystem/spanner-ai. Most of the work was copy pasting the Spanner code and adjusting it for Bigtable.

Fixes # 🦕

conventional-commit-lint-gcf[bot] commented 8 months ago

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot https://conventionalcommits.org/

daniel-sanche commented 7 months ago

I'm not sure this is the right place for this kind of content. Usually, the samples/ directory would just contain code snippets surrounded by region tags, that are then pulled into user-facing content on the docsite and/or in the library documentation in the docs/ folder. I'm not really seeing any region tags in this PR, and it seems more like a full tutorial. Are you sure this is the right place for it? Have you discussed this with the tech writers?

I'd probably suggest moving the contents of this README to a page on the docsite, pulling in some snippets like this one to show how to interact with it using Python, and linking to that page in the README here. But let me know if you've already considered that

ron-gal commented 7 months ago

Merged in https://github.com/GoogleCloudPlatform/workflows-demos/pull/114