chore: add SPOT to enum of preemptibility

googleapis / python-dataproc

This library has moved to https://github.com/googleapis/google-cloud-python/tree/main/packages/google-cloud-dataproc

Apache License 2.0

48 stars 30 forks source link

chore: add SPOT to enum of preemptibility #507

Closed tqtensor closed 1 year ago

tqtensor commented 1 year ago

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[x] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
[x] Ensure the tests and linter pass
[x] Code coverage does not decrease (if any source code was changed)
[x] Appropriate docs were updated (if necessary)

Fixes #506 🦕

Here is a simple test to create Dataproc cluster with SPOT instance. Colab

sudohainguyen commented 1 year ago

binhflow commented 1 year ago

tqtensor commented 1 year ago

Dear @parthea and @msampathkumar,

I am sorry to bother you all, but I don't know anyone to contact about this issue. This PR is pretty simple; I want to add the SPOT instance type to the enum of preemptibility to allow the Dataproc client to create a cluster with SPOT machines.

Who else should I contact to review this PR? If you know them, please tag them here.

Thank you.

parthea commented 1 year ago

Googlers see cl/499867716 with proposal to update https://github.com/googleapis/googleapis/tree/master/google/cloud/dataproc/v1