search

googleapis / python-datastore

Apache License 2.0
80 stars 44 forks source link

fix!: remove types QueryMode, QueryPlan, ResultSetStats #517

Closed gcf-owl-bot[bot] closed 10 months ago

gcf-owl-bot[bot] commented 10 months ago

fix!: remove QueryMode field from RunQueryRequest fix!: remove ResultSetStats field from RunQueryResponse fix!: remove QueryMode field from RunAggregationQueryRequest fix!: remove ResultSetStats field from RunAggregationQueryResponse

PiperOrigin-RevId: 601486345

Source-Link: https://github.com/googleapis/googleapis/commit/4a6230d5fd2034a994794681b56bc7d04d9e1efd

Source-Link: https://github.com/googleapis/googleapis-gen/commit/db652ee83ed65816ec6d910d965458d684a31c73 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGI2NTJlZTgzZWQ2NTgxNmVjNmQ5MTBkOTY1NDU4ZDY4NGEzMWM3MyJ9

parthea commented 10 months ago

We need to either delete https://github.com/googleapis/python-datastore/blob/main/google/cloud/datastore_v1/types/query_profile.py or revert https://github.com/googleapis/python-datastore/pull/512 and click the checkbox in https://github.com/googleapis/python-datastore/pull/517#issue-2101068149 to regenerate this PR, which should result in an empty change set. @daniel-sanche Which do you prefer?

daniel-sanche commented 10 months ago

Maybe reverting #512, but either option works for me.

Let me know if you need me to do anything for this

gcf-owl-bot[bot] commented 10 months ago

Owl bot is regenerating pull request 517... Build name: NjljNDgwMjMtNWRlNC00N2IyLWJmZTEtZTg4ZWQyNjliNjhk

snippet-bot[bot] commented 10 months ago

No region tags are edited in this PR.

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

parthea commented 10 months ago

Owlbot closed this PR because it would result in an empty changeset.