googleapis / python-datastore

Apache License 2.0
80 stars 44 forks source link

fix: Using end_cursor instead of skipped_cursor in Iterator to fix rare bug. #552

Closed gkevinzheng closed 4 months ago

gkevinzheng commented 4 months ago

Using end_cursor instead of skipped_cursor to fix #547. There are some rare edge cases where skipped_cursor returns an empty string with still more things to skip. Switching to end_cursor resolves this issue. Also does not reintroduce the bug that was fixed in #18, as in those cases, skipped_cursor and end_cursor are the same.

Integration tests will be coming soon, maybe in a future PR, as making a dataset that consistently replicates this issue is still under investigation.