search

googleapis / python-db-dtypes-pandas

Extension dtypes for pandas corresponding to GoogleSQL data types such as DATE, TIME, and JSON.
https://googleapis.dev/python/db-dtypes/latest/
Apache License 2.0
26 stars 6 forks source link

The build failed #275

Closed flaky-bot[bot] closed 3 months ago

flaky-bot[bot] commented 4 months ago

This test failed!

To configure my behavior, see the Flaky Bot documentation.

If I'm commenting on this issue too often, add the flakybot: quiet label and I will stop commenting.

commit: a718ce49226dd6d18cda9b22778246f5a84d3bbe buildURL: Build Status, Sponge status: failed

leahecole commented 3 months ago

numpy got a new major around when this was opened https://pypi.org/project/numpy/ - this is likely what's causing this issue

chalmerlowe commented 3 months ago

@leahecole

I am recommending we pin the version of numpy used with python 3.9 to be less than 2.0.0. See PR #277

There is a potentially unexpected interaction between pandas and numpy here. Depending on the version we use for each, we get different results in terms of pass/fail for the unit tests associated with python 3.9

numpy version pandas version unit-3.9 pass/fail
2.0.0 1.3.0 fail
2.0.0 2.2.2 pass
2.0.0 1.5.3 fail
1.26.4 1.5.3 pass
1.26.4 1.3.0 pass

This appears to be a known incompatibility between how pip resolves the dependency versions for numpy and pandas and the only current fix is to pin versions to something that "works" to avoid allowing pip to resolve into a failing state. (NOTE the linked issue references various versions of numpy and pandas, depending on the combination, inlcuding 3.9 throughout the thread, even though the title references python 3.12)

leahecole commented 3 months ago

Woof, hopefully we get to a day where they'll play nicely together! in the meantime, for Python 3.9, pinning to less than 2.0.0 feels appropriate. This table is a really helpful visualization, thank you!!