googleapis / python-documentai-toolbox

Document AI Toolbox is an SDK for Python that provides utility functions for managing, manipulating, and extracting information from the document response. It creates a "wrapped" document object from JSON files in Cloud Storage, local JSON files, or output directly from the Document AI API.
https://cloud.google.com/document-ai/docs/toolbox
Apache License 2.0
32 stars 13 forks source link

fix: Revert setup.py for`google-api-core` to `2.15.0` #280

Closed holtskinner closed 6 months ago

holtskinner commented 6 months ago

When I was locally testing fixes for another PR, I was getting these types of reports from pip.

langchain-google-vertexai 0.0.6rc0 requires google-cloud-storage<3.0.0,>=2.14.0, but you have google-cloud-storage 2.14.0rc1 which is incompatible.

I thought it was strange that I had a release candidate version of google-cloud-storage, so I tried upgrading, but then I got this error:

google-cloud-documentai-toolbox 0.13.2a0 requires google-api-core<3.0.0dev,>=2.17.1, but you have google-api-core 2.15.0 which is incompatible.

This makes me think that the latest version of google-cloud-storage currently requires google-api-core==2.15.0

parthea commented 6 months ago

The errors in https://github.com/googleapis/python-documentai-toolbox/pull/280#issue-2179457501 shouldn't happen when installing google-cloud-documentai-toolbox as pip should take care of updating dependencies to the required version. I'll approve since creating a restriction to only use the latest version of google-api-core can cause problems for users as it reduces the number of versions of google-api-core that users can choose from.