googleapis / python-firestore

Apache License 2.0
212 stars 70 forks source link

can't disable timeouts in rpc calls #885

Open daniel-sanche opened 3 months ago

daniel-sanche commented 3 months ago

Most rpc calls support passing in a retry and timeout value to configure retry parameters (example: WriteBatch.commit)

But when timeout=None, that means it uses the api default, meaning there is no way to truly disable timeouts

That said, fixing this would likely be a breaking change, and timeout can always be set arbitrarily high, so this is a low-priority fix