googleapis / python-firestore

Apache License 2.0
212 stars 70 forks source link

page_size not needed for list_documents #887

Open daniel-sanche opened 3 months ago

daniel-sanche commented 3 months ago

We have three rpcs that use pagers: ListDocuments, ListCollectionIds, and PartitionQuery

Currently, onlt list_documents provides the user with a customizable page_size arg. But all 3 rpcs abstract the pages from the users, and provide them with a flat generator over the underlying resources, so it's debatable whether the page_size argument even makes sense to provide.

To be consistent, we should either remove it from list_documents, or provide it in all three