search

googleapis / python-firestore

Apache License 2.0
219 stars 75 forks source link

pass retry configuration to each next_page in Pager calls #888

Closed daniel-sanche closed 2 months ago

daniel-sanche commented 8 months ago

We have three rpcs that use pagers: ListDocuments, ListCollectionIds, and PartitionQuery

Currently, retry and timeout values can be passed in to all 3, but it is only used in the initial call. When the next_page call is made, it uses API default values for these fields

This should be addressed at the gapic-generator level. See https://github.com/googleapis/gapic-generator-python/issues/1974

daniel-sanche commented 2 months ago

This was fixed upstream in https://github.com/googleapis/gapic-generator-python/pull/2065, merged into firestore as part of https://github.com/googleapis/python-firestore/pull/919, and released as part of https://github.com/googleapis/python-firestore/releases/tag/v2.17.2