googleapis / python-firestore

Apache License 2.0
219 stars 75 forks source link

Types for base_query.py #900

Open rgant opened 7 months ago

rgant commented 7 months ago

I cannot use FieldFilter in my projects because it is not typed.

        # It appears that filtering on document ID will not work for collect_group queries.
        # mypy error - Call to untyped function "FieldFilter" in typed context
        # Both FieldFilter & FieldPath have this issue sadly
        .where(filter=FieldFilter(FieldPath.document_id(), '==', program_id)),  # type: ignore[no-untyped-call]

Could the google.cloud.firestore_v1.base_query module be typed?