Closed rostyq closed 1 month ago
I just looked at this, and it seems like commit_time
and write_results
are inherited from BaseBatch
, but not used by the Transaction
subclass
It looks like we just need to add these lines from Batch into Transaction._commit. I think it would make sense to make the change
Currently, it is not possible to check transformation results after a successful transaction run in a decorated function without additional read access to firestore database.
Environment details
3.12.0
24.1.1
google-cloud-firestore
version:2.16.1
Steps to reproduce
@transactional
(or@async_transactional
) function using any firestore transforms (for exampleSERVER_TIMESTAMP
)Transaction
(orAsyncTransaction
) in the decorated functioncommit_time
andwrite_results
Code example