googleapis / python-pubsub

Apache License 2.0
392 stars 206 forks source link

docs(samples): Update Topic with Kinesis Ingestion Settings #1123

Closed mukund-ananthu closed 7 months ago

mukund-ananthu commented 7 months ago
  1. Add code to demonstrate updating a topic with Kinesis Ingestion Settings
  2. IngestionDataSourceSettings were added as an attribute to Topic here
snippet-bot[bot] commented 7 months ago

Here is the summary of changes.

You are about to add 1 region tag. - [samples/snippets/publisher.py:115](https://github.com/googleapis/python-pubsub/blob/04cfb213077ae0cabfc0308f64a11bb85e17975e/samples/snippets/publisher.py#L115), tag `pubsub_update_topic_kinesis_ingestion`
You are about to delete 1 region tag. - [samples/snippets/publisher.py:72](https://github.com/googleapis/python-pubsub/blob/83dc9fff13aa35518fb9b6a73472816da852d975/samples/snippets/publisher.py#L72), tag `pubsub_quickstart_create_topic_kinesis_ingestion`

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

mukund-ananthu commented 7 months ago

@parthea PTAL when free.