googleapis / python-spanner-django

Cloud Spanner database backend for Django
BSD 3-Clause "New" or "Revised" License
90 stars 28 forks source link

feat!: Support Django 4.2 #865

Closed ankiaga closed 7 months ago

ankiaga commented 7 months ago

Breaking changes

Release notes

  1. Adds support for Django 4.2
  2. Removes support for Django 2.2
  3. Only Python versions 3.8 and higher are supported
  4. Adds support for transactions in AutoCommit=True mode by default for V4.2. Transactions in AutoCommit=True mode are by default not supported in prior versions (i.e. V3.2).
    • To enable manual transactions in AutoCommit=True mode in V3.2, please set ALLOW_TRANSACTIONS_IN_AUTO_COMMIT=True your settings.py file.
    • To disable transactions in AutoCommit=True mode in V4.2, please set ALLOW_TRANSACTIONS_IN_AUTO_COMMIT=False in your settings.py file.
jaz-la commented 7 months ago

thanks a lot for working on it, left a few comments. I'm hoping that we can also have a way to bypass the version check and fall into Django 4 logic with Django 5 at our own risk. Another suggestion is to add a summary in the PR description so new developers can understand the actual difference between django 3 vs 4 without digging into the code.