search

googleapis / python-spanner-sqlalchemy

Apache License 2.0
39 stars 28 forks source link

Do you support Spanner Async Client? #249

Open maxpz opened 2 years ago

maxpz commented 2 years ago

Hi Everyone!

Does the current version support the Google Spanner Async Client? https://cloud.google.com/python/docs/reference/spanner/latest/google.cloud.spanner_v1.services.spanner.SpannerAsyncClient

If not. Are there plans to support it? I think it would be a great feature to have.

IlyaFaer commented 2 years ago

Hello, @maxpz,

Python Spanner client supports async client: https://github.com/googleapis/python-spanner/blob/451c8ebfb576d1347f0f0fb90921d5ce3abf4730/google/cloud/spanner_v1/services/spanner/async_client.py

sqlalchemy_spanner is built on top of the Python Spanner client. Thus, yes, it's possible and we're going to support it, but I don't think we have straight ETAs yet.

@asthamohta, looks like a related samples PR is stuck, by the way: https://github.com/googleapis/python-spanner/pull/758

Probably async client can be added inside the Connection class as an immutable parameter. Meaning, a connection uses one client - there should be no way to change async/non-async mode after a connection is created.

maxpz commented 2 years ago

Hi @IlyaFaer,

Thanks so much for your quick response. Great news that you are planning to support it! We'll be looking forward to using it. Please let me know if we can help with some testing.

wray27 commented 11 months ago

Hi @IlyaFaer, any updates on this?

taua-almeida commented 5 months ago

Any updates on this one?

pedrohml commented 3 months ago

no news ? 😞