search

googleapis / python-spanner-sqlalchemy

Apache License 2.0
38 stars 28 forks source link

feat: implement get_view_names() method #306

Closed IlyaFaer closed 1 year ago

IlyaFaer commented 1 year ago

Closes #303

IlyaFaer commented 1 year ago

@asthamohta, this also adds small changes to make the test suites ignore SQLAlchemy 2.0 as it includes a lot of breaking changes.

One strange thing I noticed is that the SQL query

SELECT table_name
FROM information_schema.views

Returns lists of strings. Is the information_schema.views.table_name field has the correct type? It feels like it's type is ARRAY<STRING>, not just STRING.

gcf-merge-on-green[bot] commented 1 year ago

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

yu-iskw commented 1 year ago

I don't know what kokoro is like at all. However, according to the error message, it was failed due to timeout apparently.

ERROR: Aborting VM command due to timeout of 10800 seconds
yu-iskw commented 1 year ago

@asthamohta Is there anything I can help? I would like to go ahead with the issue.