googleapis / python-spanner-sqlalchemy

Apache License 2.0
38 stars 28 forks source link

Dialect configured with sequences enabled. #325

Closed cofin closed 1 year ago

cofin commented 1 year ago

Hi, I am currently working to integrate official Spanner support within the litestar python API framework. I've noticed that if there is a model that has a sequence defined, then the Spanner dialect incorrectly emits the create statement for the sequence when executing create_all.

Upon investigation, I noticed that supports_sequences is set to True here. This appears to be incorrect. When I submit the tests using a patched version, I do not see the same failures.

Can you confirm is this is needed to be set to True? And if not, could this be changed?

Environment details

Steps to reproduce

  1. ?
  2. ?

Making sure to follow these steps will guarantee the quickest resolution possible.

Thanks!