urllib3 doesn't treat the Cookie HTTP header special or provide any helpers for managing cookies over HTTP, that is the responsibility of the user. However, it is possible for a user to specify a Cookie header and unknowingly leak information via HTTP redirects to a different origin if that user doesn't disable redirects explicitly.
Users must handle redirects themselves instead of relying on urllib3's automatic redirects to achieve safe processing of the Cookie header, thus we decided to strip the header by default in order to further protect users who aren't using the correct approach.
Affected usages
We believe the number of usages affected by this advisory is low. It requires all of the following to be true to be exploited:
Using an affected version of urllib3 (patched in v1.26.17 and v2.0.6)
Using the Cookie header on requests, which is mostly typical for impersonating a browser.
Not disabling HTTP redirects
Either not using HTTPS or for the origin server to redirect to a malicious origin.
Remediation
Upgrading to at least urllib3 v1.26.17 or v2.0.6
Disabling HTTP redirects using redirects=False when sending requests.
urllib3 previously wouldn't remove the HTTP request body when an HTTP redirect response using status 303 "See Other" after the request had its method changed from one that could accept a request body (like POST) to GET as is required by HTTP RFCs. Although the behavior of removing the request body is not specified in the section for redirects, it can be inferred by piecing together information from different sections and we have observed the behavior in other major HTTP client implementations like curl and web browsers.
A client SHOULD NOT generate content in a GET request unless it is made directly to an origin server that has previously indicated, in or out of band, that such a request has a purpose and will be adequately supported.
Affected usages
Because the vulnerability requires a previously trusted service to become compromised in order to have an impact on confidentiality we believe the exploitability of this vulnerability is low. Additionally, many users aren't putting sensitive data in HTTP request bodies, if this is the case then this vulnerability isn't exploitable.
Both of the following conditions must be true to be affected by this vulnerability:
If you're using urllib3 and submitting sensitive information in the HTTP request body (such as form data or JSON)
The origin service is compromised and starts redirecting using 303 to a malicious peer or the redirected-to service becomes compromised.
Remediation
You can remediate this vulnerability with any of the following steps:
Upgrade to a patched version of urllib3 (v1.26.18 or v2.0.7)
Disable redirects for services that you aren't expecting to respond with redirects with redirects=False.
Disable automatic redirects with redirects=False and handle 303 redirects manually by stripping the HTTP request body.
Release Notes
urllib3/urllib3 (urllib3)
### [`v1.26.18`](https://togithub.com/urllib3/urllib3/blob/HEAD/CHANGES.rst#12618-2023-10-17)
[Compare Source](https://togithub.com/urllib3/urllib3/compare/1.26.17...1.26.18)
\====================
- Made body stripped from HTTP requests changing the request method to GET after HTTP 303 "See Other" redirect responses.
### [`v1.26.17`](https://togithub.com/urllib3/urllib3/blob/HEAD/CHANGES.rst#12617-2023-10-02)
[Compare Source](https://togithub.com/urllib3/urllib3/compare/1.26.16...1.26.17)
\====================
- Added the `Cookie` header to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set via `Retry.remove_headers_on_redirect`. (`#3139 `\_)
### [`v1.26.16`](https://togithub.com/urllib3/urllib3/blob/HEAD/CHANGES.rst#12616-2023-05-23)
[Compare Source](https://togithub.com/urllib3/urllib3/compare/1.26.15...1.26.16)
\====================
- Fixed thread-safety issue where accessing a `PoolManager` with many distinct origins
would cause connection pools to be closed while requests are in progress (`#2954 `\_)
### [`v1.26.15`](https://togithub.com/urllib3/urllib3/blob/HEAD/CHANGES.rst#12615-2023-03-10)
[Compare Source](https://togithub.com/urllib3/urllib3/compare/1.26.14...1.26.15)
\====================
- Fix socket timeout value when `HTTPConnection` is reused (`#2645 `\__)
- Remove "!" character from the unreserved characters in IPv6 Zone ID parsing
(`#2899 `\__)
- Fix IDNA handling of '\x80' byte (`#2901 `\__)
### [`v1.26.14`](https://togithub.com/urllib3/urllib3/blob/HEAD/CHANGES.rst#12614-2023-01-11)
[Compare Source](https://togithub.com/urllib3/urllib3/compare/1.26.13...1.26.14)
\====================
- Fixed parsing of port 0 (zero) returning None, instead of 0. (`#2850 `\__)
- Removed deprecated getheaders() calls in contrib module. Fixed the type hint of `PoolKey.key_retries` by adding `bool` to the union. (`#2865 `\__)
### [`v1.26.13`](https://togithub.com/urllib3/urllib3/blob/HEAD/CHANGES.rst#12613-2022-11-23)
[Compare Source](https://togithub.com/urllib3/urllib3/compare/1.26.12...1.26.13)
\====================
- Deprecated the `HTTPResponse.getheaders()` and `HTTPResponse.getheader()` methods.
- Fixed an issue where parsing a URL with leading zeroes in the port would be rejected
even when the port number after removing the zeroes was valid.
- Fixed a deprecation warning when using cryptography v39.0.0.
- Removed the `<4` in the `Requires-Python` packaging metadata field.
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
[ ] If you want to rebase/retry this PR, check this box
This PR has been generated by Mend Renovate. View repository job log here.
This PR contains the following updates:
==1.26.12->==1.26.18GitHub Vulnerability Alerts
CVE-2023-43804
urllib3 doesn't treat the
CookieHTTP header special or provide any helpers for managing cookies over HTTP, that is the responsibility of the user. However, it is possible for a user to specify aCookieheader and unknowingly leak information via HTTP redirects to a different origin if that user doesn't disable redirects explicitly.Users must handle redirects themselves instead of relying on urllib3's automatic redirects to achieve safe processing of the
Cookieheader, thus we decided to strip the header by default in order to further protect users who aren't using the correct approach.Affected usages
We believe the number of usages affected by this advisory is low. It requires all of the following to be true to be exploited:
Cookieheader on requests, which is mostly typical for impersonating a browser.Remediation
redirects=Falsewhen sending requests.Cookieheader.CVE-2023-45803
urllib3 previously wouldn't remove the HTTP request body when an HTTP redirect response using status 303 "See Other" after the request had its method changed from one that could accept a request body (like
POST) toGETas is required by HTTP RFCs. Although the behavior of removing the request body is not specified in the section for redirects, it can be inferred by piecing together information from different sections and we have observed the behavior in other major HTTP client implementations like curl and web browsers.From RFC 9110 Section 9.3.1:
Affected usages
Because the vulnerability requires a previously trusted service to become compromised in order to have an impact on confidentiality we believe the exploitability of this vulnerability is low. Additionally, many users aren't putting sensitive data in HTTP request bodies, if this is the case then this vulnerability isn't exploitable.
Both of the following conditions must be true to be affected by this vulnerability:
Remediation
You can remediate this vulnerability with any of the following steps:
redirects=False.redirects=Falseand handle 303 redirects manually by stripping the HTTP request body.Release Notes
urllib3/urllib3 (urllib3)
### [`v1.26.18`](https://togithub.com/urllib3/urllib3/blob/HEAD/CHANGES.rst#12618-2023-10-17) [Compare Source](https://togithub.com/urllib3/urllib3/compare/1.26.17...1.26.18) \==================== - Made body stripped from HTTP requests changing the request method to GET after HTTP 303 "See Other" redirect responses. ### [`v1.26.17`](https://togithub.com/urllib3/urllib3/blob/HEAD/CHANGES.rst#12617-2023-10-02) [Compare Source](https://togithub.com/urllib3/urllib3/compare/1.26.16...1.26.17) \==================== - Added the `Cookie` header to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set via `Retry.remove_headers_on_redirect`. (`#3139Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.