search

googleapis / python-spanner-sqlalchemy

Apache License 2.0
38 stars 28 forks source link

fix: db.params OpenTelemetry integration issue #346

Closed gillesleblanc closed 8 months ago

gillesleblanc commented 8 months ago

When db.params are not all of the same type OpenTelemetry will log a warning.

Prevent this by stringifying values.

Also adds a SQLALCHEMY_SPANNER_TRACE_HIDE_QUERY_PARAMETERS env var to prevent logging db.params to OpenTelemetry.

Fixes #345

olavloite commented 8 months ago

@gillesleblanc Sorry for the slow turnaround on this PR. The build errors seem to be unrelated to this change. I'm working on fixing those in #351, and after that we should be able to move this one forward as well.