Open parthea opened 7 months ago
Adding do not merge
as there is an upcoming release freeze. This should be merged after the release freeze ends on November 29th.
Hi @parthea, The python-spanner-sqlalchemy presubmits are failing with below error after the latest 3.41.0 release of python-spanner,
ModuleNotFoundError: No module named 'google.cloud.spanner_v1'
From my analysis below, it looks like this PR should be merged for the presubmits to not face this issue.
Analysis
python-spanner-sqlalchemy
package setup. Analyzing more pointed out to this PR which is in draft stage. We did the same change in python-spanner in the latest release.cc: @ankiaga @olavloite
@harshachinta,
Please can you check if the issue is resolved with this PR which removes editable installations from tests? https://github.com/googleapis/python-spanner-sqlalchemy/pull/383
There are limitations for editable installations, and this type of installation is still listed as experimental on pypa.io: https://setuptools.pypa.io/en/latest/userguide/development_mode.html#limitations
We may be able to improve support for editable installations by switching to a src
layout instead of a flat
layout.
https://github.com/googleapis/google-cloud-python/issues/12078
This PR:
pkg_resources
to prepare for adding python 3.12 supportgoogle/cloud/sqlalchemy_spanner
To obtain the version at runtime, use
google.cloud.sqlalchemy_spanner.__version__
Fixes #337 🦕