search

googleapis / python-spanner-sqlalchemy

Apache License 2.0
38 stars 28 forks source link

tests: remove editable install in tests #383

Closed parthea closed 5 months ago

parthea commented 5 months ago

There are limitations for editable installations, and this type of installation is still listed as experimental on pypa.io: https://setuptools.pypa.io/en/latest/userguide/development_mode.html#limitations

As a longer term fix, we may be able to improve support for editable installations by switching to a src layout instead of a flat layout. https://github.com/googleapis/google-cloud-python/issues/12078

ankiaga commented 5 months ago

@parthea Can we please get this PR merged?

parthea commented 5 months ago

@ankiaga This PR is ready for review. PTAL

ankiaga commented 5 months ago

@parthea I have included these changes in https://github.com/googleapis/python-spanner-sqlalchemy/pull/384 as we couldn't merge this PR because of existing test failures. I could also not merge my PR (to fix tests) without these change after latest release of python-spanner repo so both the changes have been included in https://github.com/googleapis/python-spanner-sqlalchemy/pull/384 and we can close this PR. Let me know if that sounds good