search

googleapis / python-spanner-sqlalchemy

Apache License 2.0
38 stars 28 forks source link

fix: Index on a table containing columns with no sort order fails while reflecting the table #400

Open mmahmed opened 2 weeks ago

mmahmed commented 2 weeks ago

Fixes #399

  1. Ignore None order as SQLAlchemy only processes ASC, DESC
  2. SQLAlchemy requires order in lowercase (asc, desc)
google-cla[bot] commented 2 weeks ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

conventional-commit-lint-gcf[bot] commented 2 weeks ago

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot https://conventionalcommits.org/