googleapis / release-please-action

automated releases based on conventional commits
Apache License 2.0
1.73k stars 213 forks source link

Parse Error for commit with multiple features #1024

Closed dgokcin closed 3 months ago

dgokcin commented 3 months ago

Hello and thank you for this action.

I’m encountering an issue with release generation for the following commit. According to the release-please documentation, I expect the commit below to generate 2 features and 1 bug fix with a simple release. However, the release job is failing to create a release with the message: commit could not be parsed:.

Here is the commit in question:

feat: add new key mappings and improve copilot chat prompts

- Added a new key mapping to toggle the terminal in vscode_keymaps.lua
- Refactored copilot chat prompts to use a common commit prompt variable
- Updated the pull request prompt to include more detailed instructions
- Added spaces for better alignment in copilot chat key mappings
- Improved descriptions for copilot chat commands

feat: use diff with main branch for PR

fix: update git diff command to use origin/main branch

- Changed the git diff command to use origin/main instead of main
- Updated the system prompt for pull request creation
- Added an example output for the `gh pr create` command
- Ensured backticks are properly escaped in the command
- Removed an unnecessary newline character in the command

Could you please assist in resolving this issue?

Thank you!

dgokcin commented 3 months ago

After further examination of the release-please source code, the bulleted list in only the first commit of the squash merge is handled, hence above commit fails. Interestingly if the second bulleted list is indented one level, it works. Also, using BEGIN_NESTED_COMMIT and END_NESTED_COMMIT keywords in the squash commit also works.

feat: add new key mappings and improve copilot chat prompts

- Added a new key mapping to toggle the terminal in vscode_keymaps.lua
- Refactored copilot chat prompts to use a common commit prompt variable
- Updated the pull request prompt to include more detailed instructions
- Added spaces for better alignment in copilot chat key mappings
- Improved descriptions for copilot chat commands

feat: use diff with main branch for PR

fix: update git diff command to use origin/main branch

    - Changed the git diff command to use origin/main instead of main
    - Updated the system prompt for pull request creation
    - Added an example output for the `gh pr create` command
    - Ensured backticks are properly escaped in the command
    - Removed an unnecessary newline character in the command