search

googleapis / release-please-action

automated releases based on conventional commits
Apache License 2.0
1.61k stars 207 forks source link

Modifying release please manifest created a breaking change with old commits #822

Open VividLemon opened 11 months ago

VividLemon commented 11 months ago

TL;DR

https://github.com/bootstrap-vue-next/bootstrap-vue-next/actions/runs/6067806713/job/16459946256 https://github.com/bootstrap-vue-next/bootstrap-vue-next/pull/1414 https://github.com/bootstrap-vue-next/bootstrap-vue-next/pull/1414/commits/704ebca319258a788caa3c18ad0f6a5f1acb9a97

Changing the manifest created a breaking change release for a unnecessary package. Which was rather annoying. If the package was not pre alpha this would be a big issue as I've had issues with "release-as" in the manifest. It's never seemed to work for me.

Expected behavior

Not to create a breaking change version.

Observed behavior

At most the commit message should create a minor version.

Action YAML

https://github.com/bootstrap-vue-next/bootstrap-vue-next/blob/main/.github/workflows/release-main.yaml

Log output

Posted above

Additional information

No response

VividLemon commented 11 months ago

The commits that it grabbed are very old and have already been indexed. So, it's strange that they were grabbed again.

chingor13 commented 8 months ago

I think this is a race condition issue when tagging a new release and then immediately trying to open a new PR. Example: https://github.com/google-github-actions/release-please-action/pull/911

VividLemon commented 8 months ago

Strange. I recall all that I did was commit the manifest. Nothing particularly out of the ordinary