search

googleapis / release-please-action

automated releases based on conventional commits
Apache License 2.0
1.7k stars 212 forks source link

No tag if setting release to draft #833

Closed arvnik closed 11 months ago

arvnik commented 1 year ago

TL;DR

Hi! It seems that the tag is not properly created and pushed if I set the draft parameter to true. Changelog looks correct and release is created as expected but the tag isn't there.

Expected behavior

No response

Observed behavior

No response

Action YAML

on:
  push:
    branches:
      - main

permissions:
  contents: write
  pull-requests: write

name: Release Please

jobs:
  release-please:
    runs-on: ubuntu-latest
    steps:
      - uses: google-github-actions/release-please-action@v3
        with:
          release-type: node
          package-name: release-please-action
          token: ${{ token }}
          include-v-in-tag: false
          draft-pull-request: true
          draft: true

Log output

No response

Additional information

No response

chingor13 commented 11 months ago

We don't explicitly create tags in release-please when creating releases. When publishing a release, it will create the tag (or re-use an existing one).

If you think the behavior should be to create the tag even if the release is a draft, then please open a new issue on the upstream https://github.com/googleapis/release-please library.