search

googleapis / release-please-action

automated releases based on conventional commits
Apache License 2.0
1.7k stars 212 forks source link

ci: test on node 18 and 20 #835

Closed chingor13 closed 1 year ago

chingor13 commented 1 year ago
regseb commented 1 year ago

There's also the Node 16 in the .github/workflows/release-please.yaml file. I think you should upgrade to Node 20.

regseb commented 1 year ago

There is 'node16' in action.yml file. I don't know how this file works, but perhaps this version should also be changed.

chingor13 commented 1 year ago

There is 'node16' in action.yml file. I don't know how this file works, but perhaps this version should also be changed.

That will actually change the runtime for the action, which we will do separately before release.